Skip to content

Default RFP proposals to recommended ordering - #1321

Closed
nicktytarenko wants to merge 1 commit into
mainfrom
feat/rfp-recommended-ordering
Closed

nicktytarenko wants to merge 1 commit into
mainfrom
feat/rfp-recommended-ordering

Conversation

@nicktytarenko

@nicktytarenko nicktytarenko commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

What

The Proposals tab on an RFP page now ranks proposals with the backend's new recommended ordering by default.
"Recommended" is the first and selected option in that tab's sort menu.

Depends on ResearchHub/researchhub-backend#4537.

How

  • proposalSortAndFilterConfig.ts: adds recommended to ProposalSortOption and a GRANT_SORT_OPTIONS list (Recommended + the existing options).
  • FundraiseContext.tsx: when the provider has a grantId, the default sort is recommended and the context exposes GRANT_SORT_OPTIONS; otherwise it stays best with the existing options. A sort that isn't valid for the current scope falls back to that scope's default, so recommended is never sent without grant_id.
  • ProposalSortAndFilters.tsx: renders the options from the context.

The main feed's Proposals tab (/fund/proposals) has no grantId and is unchanged. The /consciousness live proposals list is scoped to its RFP, so it also picks up the recommended order. Nested grant.applications from the grant feed come pre-ranked from the backend and aren't re-sorted on the client.

The funding feed now accepts ordering=recommended alongside grant_id. When the
proposals feed is scoped to one RFP, default to it and offer it in the sort
menu. Unscoped feeds keep "best" and never send recommended.
@nicktytarenko
nicktytarenko requested a review from a team as a code owner November 21, 2026 12:37
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
web Ready Ready Preview Nov 21, 2026 12:38pm UTC

Request Review

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-21T12:37:35.345659Z
We couldn’t complete this review. Comment @codex review to try again.
bd5fd42 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@sonarqubecloud

Copy link
Copy Markdown

@nicktytarenko

Copy link
Copy Markdown
Member Author

Not needed: the backend now applies the ranking to ordering=best when grant_id is passed (ResearchHub/researchhub-backend#4537).

@nicktytarenko
nicktytarenko deleted the feat/rfp-recommended-ordering branch November 21, 2026 13:58

This branch was successfully deployed

1 active deployment
Preview — bd5fd42d Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant